Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make taxcalc an optional dependency #52

Merged
merged 9 commits into from
Dec 5, 2019
Merged

Make taxcalc an optional dependency #52

merged 9 commits into from
Dec 5, 2019

Conversation

MaxGhenis
Copy link
Collaborator

Fixes #39 using the pandas approach specified there.

I've tested that taxcalc-dependent functions like calc_df correctly throw an error when taxcalc isn't installed, and work normally when taxcalc is installed.

@pep8speaks
Copy link

pep8speaks commented Dec 5, 2019

Hello @MaxGhenis! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-05 18:49:58 UTC

@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #52 into master will increase coverage by 4.19%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   66.66%   70.85%   +4.19%     
==========================================
  Files          22       24       +2     
  Lines         423      501      +78     
==========================================
+ Hits          282      355      +73     
- Misses        141      146       +5
Impacted Files Coverage Δ
microdf/taxcalc.py 73.91% <100%> (+1.18%) ⬆️
microdf/_optional.py 100% <100%> (ø)
microdf/tests/test_taxcalc.py 75% <55.55%> (-25%) ⬇️
microdf/tests/test_optional_dependency.py 97.22% <97.22%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65d4355...847f5ce. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider splitting out taxcalc features
2 participants