-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add n65 field for number of people age 65 or older #243
Comments
@MaxGhenis I think adding an n65 variable would be pretty straightforward. We have a potential new contributor looking for an easy entry project so I'll probably pass this on to her, unless someone can think of a reason against adding n65. |
@andersonfrailey said:
I see the benefit of starting out a new contributor with an easy project, but I'm not sure this is the most efficient way to accomplish the task. Adding a The other approach would be to simply provide @MaxGhenis' code as part of Tax-Calculator and add a test of that new code. That second approach would avoid all the costs of adding a "derived" variable to both CPS and PUF input data. I'd be happy to implement the second approach, but perhaps it is easy enough to assign to the new contributor. What do you think, @andersonfrailey ? |
Good points, @martinholmer. I think it's easy enough to assign to the new contributor. Do you think it would be best to add the function as a method of the calculator class or put it in |
@MaxGhenis said in Tax-Calculator issue #243:
@MaxGhenis, Thanks for the suggestion/request, but it seems a little more complicated than I first thought.
So, this variable indicates the presence of one (or more) elderly dependents. It is not a count of the number of elderly dependents. So, the formula @MaxGhenis uses (see above) is the best he can do with existing data, but it it not correct in all cases because of the data limitation. Perhaps this limitation is OK for the work @MaxGhenis is doing, but I'm reluctant to add this "approximate" code to Tax-Calculator. @andersonfrailey, would it be possible to construct a |
|
@MaxGhenis, the bug was on the TaxData side. In PR #194 I updated the @martinholmer, it wouldn't be too much effort to construct an |
Here is what I get for the values of
So, @MaxGhenis, you're right about the CPS data having more detail (that is, the exact count of elderly dependents in the filing unit). But it appears as if the PUF data do not have that kind of detail. So, adding @MaxGhenis' @MaxGhenis, why not just use your |
Would it be OK to implement |
@andersonfrailey said:
@andersonfrailey, Are you saying you can construct an accurate If not, then I don't think we should create any If so, then why not change the name of |
@MaxGhenis said:
No, we are not going to get in the business of including things in Tax-Calculator that work only with one or another of the input data sets. |
@martinholmer I can create an |
|
@andersonfrailey and @MaxGhenis, Thanks for all the input on this issue. Seems, like we should backtrack on #194 and make a new Then in Tax-Calculator, I'll change the documentation to reflect the new Does that make sense as a work plan on this issue? |
Sounds good. Based on this line it seems like the dependent care above-the-line deduction may have been miscomputed using CPS data so far, is that right? Will the |
@MaxGhenis said in taxdata issue #243:
@codykallen, my guess is that you added the elderly-dependent-care deduction logic to Tax-Calculator because it was part of the early Trump tax reform proposals. In those proposals, was the maximum deduction amount ( Here is the relevant JSON in
The logic of the non-elderly-care deduction uses |
@martinholmer, although you have correctly identified which proposal prompted the addition of the As with many campaign reforms, there is substantial uncertainty regarding the precise details intended. I wrote a memo on the dependent care provisions back in 2016, and I'll summarize what we knew then.
The deduction would be phased out for individuals earning more than $250,000 or couples earning more than $500,000. The most detailed information can be found in their child care plan fact sheet: https://assets.donaldjtrump.com/CHILD_CARE_FACT_SHEET.pdf Generally, I think it is a reasonable assumption that the $5000 elderly care deduction amount is also per dependent, although I don't expect that there are many filers with multiple elderly dependents. |
@codykallen, Sorry about misidentifying you as the author of |
The |
Low-priority, but I've found myself needing to use the number of people age 65+ in tax units a few times. This is straightforward to calculate when using a dataframe, e.g. I've used this function:
But this might not be obvious to all users, so having it in the data might be helpful. Alternatively, this
n65
function could be made available intaxcalc
.The text was updated successfully, but these errors were encountered: