Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Test] Should not hardcode -Verbose switches on commands #20

Closed
MariusStorhaug opened this issue Mar 4, 2024 · 0 comments · Fixed by #53
Closed

[New Test] Should not hardcode -Verbose switches on commands #20

MariusStorhaug opened this issue Mar 4, 2024 · 0 comments · Fixed by #53

Comments

@MariusStorhaug
Copy link
Contributor

MariusStorhaug commented Mar 4, 2024 •
edited
Loading

The whole point about [CmdLetBinding()] is to be able to control that from the "outside".

You should however be able to explicitly hide verbose by adding -Verbose:$false
@MariusStorhaug MariusStorhaug mentioned this issue Apr 14, 2024
Merged
8 tasks
MariusStorhaug added a commit that referenced this issue Apr 14, 2024
@MariusStorhaug
🩹 [Patch]: Add test where enabling -Verbose in a function is not al…
d08f4fe 
…lowed (#53)

## Description

- One of the points of having `[Cmdletbinding()]` is to be able to turn
on verbosity logging from outside the function. This test now checks for
enabling switches `-Verbose` or `-Verbose:$true`.
  - Fixes #20 

## Type of change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] 📖 [Docs]
- [ ] 🪲 [Fix]
- [x] 🩹 [Patch]
- [ ] ⚠️ [Security fix]
- [ ] 🚀 [Feature]
- [ ] 🌟 [Breaking change]

## Checklist

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🩹 [Patch]: Add test where enabling -Verbose in a function is not allowed PSModule/Test-PSModule
1 participant
@MariusStorhaug