Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to comments to fix generation problems with RTD #6

Closed
wants to merge 2 commits into from
Closed

Conversation

swcurran
Copy link
Contributor

Signed-off-by: Stephen Curran swcurran@gmail.com

Minor tweaks to the comments used to generate the RTD documents, but ones that prevented the display of the code. Please push these fixes through as soon as possible so that we have good docs online - currently they are blank. I didn't realize just how fragile these where - a small mistake prevents large chunks/all of the documentation from being produced.

Code related problems:

  • bad indent of a list (no need to indent a bullet list)
  • a ":" missing after "return"
  • Missing blank line between "::" indicator and JSON
  • Missing blank line between end of JSON and the """ indicator

Thanks

Signed-off-by: Stephen Curran <swcurran@gmail.com>
@swcurran
Copy link
Contributor Author

BTW - can pylint pick these up? Or do we need to look at you being able to run the rtd generator locally?

I definitely need to look at the warnings produced from the RTD runs on the site.

Signed-off-by: Stephen Curran <swcurran@gmail.com>
@sklump
Copy link
Collaborator

sklump commented Nov 20, 2018

pylint cannot pick these up.

Actually pylint is a lousy tool for a lot of newer python syntax even, but there is nothing better. We're muddling through.

@sklump
Copy link
Collaborator

sklump commented Nov 21, 2018

Will incorporate the spirit of these changes in next revision, and track through file name migration as I finish the refactoring for the new encoder and deep predicate support.

@swcurran
Copy link
Contributor Author

Spirit sounds good - as long as the syntax is right :-). Do you have a way to run rtd to verify that the format is correct? I set up a script that calls sphinx using docker if that would help. Do let me know when you have put these in so I can get them in my copy.

@sklump
Copy link
Collaborator

sklump commented Nov 21, 2018

1.6.38 includes.

@sklump
Copy link
Collaborator

sklump commented Nov 21, 2018

Also, I can run sphinx now.

@sklump sklump closed this Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants