Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed wrong method name for setting editableAnnotationsTypes to setEd… #21

Closed
wants to merge 6 commits into from
Closed

fixed wrong method name for setting editableAnnotationsTypes to setEd… #21

wants to merge 6 commits into from

Conversation

bocodigital
Copy link

editableAnnotationTypesForPSPDFDocumentWithJSON

@steviki
Copy link
Contributor

steviki commented Mar 13, 2017

Thanks for the PR, we really appreciate it.

Could you perhaps rebase this PR to master, as the print sharing options has already been added there.

Also, setEditableAnnotationTypesForPSPDFDocumentWithJSON should rather be setEditableAnnotationTypesForPSPDFViewControllerWithJSON, as it modifies PSPDFViewController rather than PSPDFDocument.

Other than that, everything looks good to me.

@steviki
Copy link
Contributor

steviki commented May 19, 2017

These fixes already landed on master in 4b9a813 and e387139.
I'm going ahead and will close this PR.
Thanks again for your contribution!

@steviki steviki closed this May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bocodigital @steviki