Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention cordova-plugin-cocoapods-support in the README #73

Merged
merged 3 commits into from
Apr 11, 2019
Merged

Mention cordova-plugin-cocoapods-support in the README #73

merged 3 commits into from
Apr 11, 2019

Conversation

radazzouz
Copy link
Contributor

Details

Update the README to mention cordova-plugin-cocoapods-support

Acceptance Criteria

  • The README is updated
  • Right before merging, update the package version and publish npm.

@radazzouz radazzouz requested a review from steviki April 10, 2019 18:54
@radazzouz radazzouz self-assigned this Apr 10, 2019
@steipete
Copy link
Contributor

lgtm. Can we expand the steps required here if CocoaPods are used?

@radazzouz radazzouz force-pushed the rad/mention-cordova-plugin-cocoapods-support branch from 7bbe80a to 158f795 Compare April 11, 2019 14:36
@radazzouz radazzouz force-pushed the rad/mention-cordova-plugin-cocoapods-support branch from 158f795 to d833175 Compare April 11, 2019 14:37
steviki
steviki approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@radazzouz radazzouz merged commit 20381e7 into master Apr 11, 2019
@radazzouz radazzouz deleted the rad/mention-cordova-plugin-cocoapods-support branch April 11, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviki steviki steviki approved these changes

Assignees

@radazzouz radazzouz

Labels
enhancement READY TO REVIEW
Projects
None yet
Milestone
No milestone
3 participants
@radazzouz @steipete @steviki