Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong branch for unstable ? #227

Closed
jrfnl opened this issue Jun 28, 2018 · 3 comments
Closed

Wrong branch for unstable ? #227

jrfnl opened this issue Jun 28, 2018 · 3 comments

Comments

@jrfnl
Copy link

jrfnl commented Jun 28, 2018

I'm wondering how the unstable branch is determined.

If no aliases RC/beta etc branches are found and no alias is passed via composer.json, to me, it looks like this always displays dev-master, while for projects using GitFlow, master will be the stable branch and (dev-)develop the unstable branch.

Could the GitHub API be used to retrieve the default branch and display that instead ?
The branch name can be retrieved via a call to GET /repos/:owner/:repo and looking at the value returned by default_branch.
See: https://developer.github.com/v3/repos/#get

Related #174

@JellyBellyDev
Copy link
Member

Currently the logic goes to look for the value set for branch-alias, alternatively it sets master as value.
Would you like to do a PR using the logic you proposed in the absence of the branch-alias information?
You should apply the change to the new version for we are going to put online: https://github.com/PUGX/badge-poser/tree/release/v3.0.0
Thank you

@jrfnl
Copy link
Author

jrfnl commented Jul 9, 2018

Would you like to do a PR using the logic you proposed in the absence of the branch-alias information?

No. I already spent too much time looked at the code and couldn't for the life of me figure out where to change it in this repo. If it would have been an obvious change, you would have received a PR already instead of an issue.

I haven't looked at the new repo/code yet, but can only do so much.

@JellyBellyDev
Copy link
Member

JellyBellyDev commented Jul 11, 2018

I checked the logic.
All release prerings on packagist are taken into consideration:
https://packagist.org/packages/digipolisgent/robo-drupal-console
On packagist there is dev-master. dev-master in the absence of branch-alias wins over everything on unstable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants