Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Sf2.3 and remove unused dependencies #45

Merged
merged 3 commits into from
Jun 5, 2013

Conversation

agiuliano
Copy link
Member

No description provided.

@eux
Copy link
Member

eux commented Jun 5, 2013

I counter checked the upgrade and it works but why change the exception in the test? wouldn't it be better to eliminate the tests of the private/protected methods as stated in issue #43?

@agiuliano
Copy link
Member Author

Because of how phpunit manage the warning and error exceptions.
The tests, by the way, have to been deleted

@eux
Copy link
Member

eux commented Jun 5, 2013

👍

1 similar comment
@liuggio
Copy link
Member

liuggio commented Jun 5, 2013

👍

@toretto460
Copy link
Contributor

👍

@leopro
Copy link
Member

leopro commented Jun 5, 2013

app/config/parameters.yml should be ignored, no?

@agiuliano
Copy link
Member Author

effectively, yes, but in production parameter.yml must be shared.
Do I add the commit?

@agiuliano
Copy link
Member Author

I've modified gitignore deleting .idea directory. It have to stai in global gitignore and not in the project's gitignore

@liuggio
Copy link
Member

liuggio commented Jun 5, 2013

good spot @leopro and @agiuliano for me this could be closed [EDIT] ops I mean merged :)

@eux
Copy link
Member

eux commented Jun 5, 2013

👍

leopro added a commit that referenced this pull request Jun 5, 2013
Upgrade to Sf2.3 and remove unused dependencies
@leopro leopro merged commit 379760a into PUGX:master Jun 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants