-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Sf2.3 and remove unused dependencies #45
Conversation
I counter checked the upgrade and it works but why change the exception in the test? wouldn't it be better to eliminate the tests of the private/protected methods as stated in issue #43? |
Because of how phpunit manage the warning and error exceptions. |
👍 |
1 similar comment
👍 |
👍 |
app/config/parameters.yml should be ignored, no? |
effectively, yes, but in production parameter.yml must be shared. |
I've modified gitignore deleting .idea directory. It have to stai in global gitignore and not in the project's gitignore |
good spot @leopro and @agiuliano for me this could be |
👍 |
Upgrade to Sf2.3 and remove unused dependencies
No description provided.