Dockerfile fixes to install from project, not PyPI #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks again, @malvidin! I've made some changes around minimizing layer size, as well as updating xorsearch and exiftool versions and url fixes. If all looks good, I will go ahead and merge soon. |
|
It's fine for them to be part of the same RUN command and Dockerfile. I merged them to ensure that there aren't more layers than necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made multiple changes to the Dockerfile, primarily so that the version of stoQ that is built is based on the project, not the release on PyPI.
The change to use exiftool.org instead of the sno.phy.queensu.ca URL was because of the current 302 redirect to htps://www.sno.phy.queensu.ca/