Squadron nationality support #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… SquadronNationalitySupport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for specifying nationality for squadrons so that pilots generated/assigned to the squadron get a suitable name.
Example squadron's json with optional 'nationalityOverride' property:
{ "country": "GERMANY", "squadronId": 20111015, "name": "15 Escuadrilla Azul/JG27", "fileName": "15 Escuadrilla Azul.json", "skill": 65, "serviceId": 20101, "unitIdCode": "", "subUnitIdCode": "", "tacticalCodeStyle": -1, "nationalityOverride": "Spain", "squadronTacticalCodeColorOverride": "BLACK", "planeAssignments": [ { "archType": "bf109e", "squadronIntroduction": "19410901", "squadronWithdrawal": "19420520" }, ... etc.Reworked slightly the code for the name generation so that all files matching First/LastNamesX.txt are parsed and used accordingly (in the above example, FirstNamesSpain.txt and LastNamesSpain.txt should be present).
While doing these changes I also figured that being limited to only ASCII char names is a bit sad: it works fine for British/US and latinized Russian names, but even for Germans (as well as the Spanish ones) it robs a bit from the authentic feeling when looking at the roster. Basically the names file (as well as player characters name when creating new campaign) may contain non-ASCII characters, but their normalized versions go to the mission generation. When parsing the logs, then the matching is also done by making use of the normalized name.