MS5611 failed to work on RPi on I2C bus #13814
Conversation
SalimTerryLi
changed the title
|
Nice work @SalimTerryLi. Are the white space changes intentional (https://github.com/PX4/Firmware/pull/13814/files)? |
dagar
added
Drivers 🔧
| if (bus.dev->init() != OK) { | ||
| PX4_ERR("MS5611 start failed"); | ||
| delete bus.dev; | ||
| bus.dev = NULL; |
There was a problem hiding this comment.
In c++ use nullptr in place of NULL.
| return ret; | ||
| } | ||
|
|
||
| return probe(); |
There was a problem hiding this comment.
Actually, this is can and should be fixed lower level. In the NuttX version of the I2C wrapper I2C::init() calls probe. https://github.com/PX4/Firmware/blob/cc7a0cd69dec52db7816a24e58e782a82a8243a3/src/lib/drivers/device/nuttx/I2C.cpp#L140
I'll bring the posix version into sync. https://github.com/PX4/Firmware/blob/cc7a0cd69dec52db7816a24e58e782a82a8243a3/src/lib/drivers/device/posix/I2C.cpp#L74
There was a problem hiding this comment.
Can you delete this now and retest? #13818 has merged.
I just did 'Reformat Code' in Clion... |
Co-Authored-By: Daniel Agar <daniel@agar.ca>
We use astyle with this configuration. https://github.com/PX4/Firmware/blob/master/Tools/astyle/astylerc If it didn't already exist I would have gone with clang-format, but it's hard to transition from one tool to another without thousands of minor changes. With astyle installed locally you can run |
I did 'Reformat code' before |
|
Confirmed ms5611 is still working on NuttX.
|
Describe problem solved by this pull request
Make MS5611 available on RPi with IIC bus.
MS5611 on /dev/i2c-1
start-up command:
ms5611 start -I -T 5611