Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBRK_FLIGHTTERM: Does not affect takeoff failure safety detection #14972

Merged
merged 4 commits into from May 28, 2020
Merged

CBRK_FLIGHTTERM: Does not affect takeoff failure safety detection #14972

merged 4 commits into from May 28, 2020

Conversation

hamishwillee
Copy link
Contributor

Improve description. @RicardoM17 - better?

@hamishwillee hamishwillee requested a review from bresch May 25, 2020 22:22
RicardoM17
RicardoM17 suggested changes May 26, 2020
View reviewed changes
Copy link
Contributor

@RicardoM17 RicardoM17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good but I would also mention something about the takeoff failure detection exception in FD_FAIL_P and FD_FAIL_R parameters as those values are still relevant during the take-off phase regardless of the value of CBRK_FLIGHTTERM.

bresch
bresch previously approved these changes May 26, 2020
View reviewed changes
@hamishwillee
Copy link
Contributor Author

Thanks @RicardoM17 - have clarified those too.

@bresch Can you please review the additional changes. If you're happy please also MERGE. I don't have rights to merge.

bresch
bresch approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hamishwillee !

@hamishwillee
Copy link
Contributor Author

Thanks for removing the trailing whitespace. @bresch if this is good, I can't merge.

@bresch bresch self-requested a review May 28, 2020 06:30
@bresch bresch merged commit 1485353 into master May 28, 2020
@bresch bresch deleted the hamishwillee-flight_term_pparm branch May 28, 2020 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RicardoM17 RicardoM17 RicardoM17 requested changes

@bresch bresch bresch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hamishwillee @RicardoM17 @bresch