Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger: add mode to enable/disable logging via AUX1 RC channel #12100

Merged
merged 2 commits into from
May 29, 2019
Merged

Logger: add mode to enable/disable logging via AUX1 RC channel #12100

merged 2 commits into from
May 29, 2019

Conversation

bkueng
Copy link
Member

@bkueng bkueng commented May 29, 2019 •
edited by AuterionWrikeBot
Loading

julianoes
julianoes reviewed May 29, 2019
View reviewed changes
src/modules/logger/logger.cpp Outdated Show resolved Hide resolved
src/modules/logger/logger.cpp Outdated Show resolved Hide resolved
src/modules/logger/logger.h Show resolved Hide resolved
src/modules/logger/params.c Outdated Show resolved Hide resolved
julianoes
julianoes approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@bkueng bkueng merged commit ed9d25a into master May 29, 2019
@bkueng bkueng deleted the logger_aux1_arming branch May 29, 2019 09:41
@jstrebel
Copy link

jstrebel commented May 29, 2019 •
edited
Loading

Thank you Beat this is great news. I will test this on coming Saturday. I am not that familiar with the selection of the test versions. I see this is not in the master. Is my assumption correct, if I build it as "make px4_fmu-v5_default" then I get the code with your changes? Of course first a clone from github PX4.

@bkueng
Copy link
Member Author

bkueng commented May 29, 2019

It is now on master. If you select the latest development build in QGC on Saturday, you should have it.
Otherwise you can build master with make px4_fmu-v5_default.
You might also have to set SDLOG_MODE manually to 3 if QGC does not have the metadata yet.

@jstrebel
Copy link

jstrebel commented Jun 1, 2019

I promised to test it this saturday.
Two test: px4 v3 and px4 v5 worked successfully on ground. Next steps are flying
Thx

@weekly-digest weekly-digest bot mentioned this pull request Jun 2, 2019
Closed
@jstrebel
Copy link

jstrebel commented Jun 9, 2019

Beat, I did a few flights during the last week testing this feature. All worked ok.
Would be great to see this in 1.9.1 Jakob

@julianoes
Copy link
Contributor

@jstrebel I don't think we would add features into a patch release. Patch releases are only for bugfixes.

@mrpollo mrpollo mentioned this pull request Nov 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianoes julianoes julianoes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkueng @jstrebel @julianoes