Improve Python dependency notes #13949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now check individually for empy and genmsg. Also, my recommendation is to use pip3 as a user to install the dependencies as this is least intrusive and should work on all platforms.
In more detail: - Change shebang to Python 3. - Suggest installation using pip3 as user.
TSC21
previously approved these changes
Jan 15, 2020
This removes the cmake check for jinja2 and moves it to the respective Python scripts.
This should be helpful as developers need to migrate to Python 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the switch to Python 3 we should also make sure the dependency notes/warnings are appropriate.
Also, my recommendation is to use pip3 as a user to install the dependencies as this is least intrusive and should work on all platforms.