Implemented SK450 DeadCat frame support #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
|
You will want to rebase this onto master like this: https://help.github.com/articles/about-git-rebase/ I expect one conflicting line, but since you did both changes, that should be trivial. I assume this is flight tested? If / once it is, I'm happy to merge it. Thanks! |
Implemented the way to specify motor output scale which is required for SK450 DeadCat as it has asymetrical arms (front arms are longer than back ones)
Lowered the pwm min
Added mixer check to set MAV_TYPE correctly
anton-matosov
force-pushed
the
SK450DeadCat.v2
branch
from
b1059e3
to
ba89c9e
Compare
|
Rebased and flight tested. Works fine |
|
What is the difference between the 'w' / wide mixer and the dc mixer? |
|
They have different angles (5 deg difference for front rotors, 6 deg back). In addition DC's one has extra correction for the arms length (back arms are 96% of the front) |
|
Ok, got it! |
LorenzMeier
added a commit
that referenced
this pull request
Jan 8, 2015
Implemented SK450 DeadCat frame support
|
Changes Unknown when pulling ba89c9e on anton-matosov:SK450DeadCat.v2 into * on PX4:master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented SK450 DeadCat frame support
Implemented the way to specify motor output scale which is required for SK450 DeadCat as it has asymetrical arms (front arms are longer than back ones)