Fix parameters on Snapdragon #4027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@julianoes This works, I get all params on snapdragon! |
|
Please rebase and merge, looking good to me. @Tumbili please test on Pixhawk ASAP |
julianoes
force-pushed
the
fix_params_snapdragon
branch
from
ecf5bcf
to
61baef4
Compare
|
Rebased and applied to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the parameter download for Snapdragon. The reason that not all parameters did arrive before was that the param index was set to -1 if they hadn't been "used" before, however we ignore the "used" flag for now on that platform.
Additionally, the mavlink stream of PARAM_VALUE is sped up if the connection is made over UDP.
@LorenzMeier please comment on 3ded0e3, not sure if this is the correct way, and not sure if we'll see nasty effects over suboptimal wifi connections.