AUX outputs param setup fix

[LorenzMeier]

No description provided.

[LorenzMeier]

Flash overflow. So we're just at the limit.

[LorenzMeier]

@tops4u It would be great if you could test this.

[tops4u]

@LorenzMeier Checked and failed : See #5989

[LorenzMeier]

@tops4u This works now, I just tested it.

Paramter PWM_AUX_DISARMED set to 1490 and rebooted:

pwm info -d /dev/pwm_output1
device: /dev/pwm_output1
channel 1: 1490 us (alternative rate: 50 Hz failsafe: 0, disarmed: 1490 us, min: 1000 us, max: 2000 us, trim:  0.00)
channel 2: 1490 us (alternative rate: 50 Hz failsafe: 0, disarmed: 1490 us, min: 1000 us, max: 2000 us, trim:  0.00)
channel 3: 1490 us (alternative rate: 50 Hz failsafe: 0, disarmed: 1490 us, min: 1000 us, max: 2000 us, trim:  0.00)
channel 4: 1490 us (alternative rate: 50 Hz failsafe: 0, disarmed: 1490 us, min: 1000 us, max: 2000 us, trim:  0.00)
channel 5: 1 us (default rate: 50 Hz failsafe: 0, disarmed: 0 us, min: 1000 us, max: 2000 us, trim:  0.00)
channel 6: 1 us (default rate: 50 Hz failsafe: 0, disarmed: 0 us, min: 1000 us, max: 2000 us, trim:  0.00)
channel group 0: channels 1 2 3 4
channel group 1: channels 5 6

[LorenzMeier]

@julianoes Can you briefly review?

[LorenzMeier]

@kd0aij Can you review and maybe test this one?

[kd0aij]

Is 17 the maximum length of a parameter name?
Everything else looks good to me.

[LorenzMeier]

Param name + 1 (null termination). See: http://pubs.opengroup.org/onlinepubs/7908799/xsh/strncpy.html.

[kd0aij]

I knew that exactly 17 bytes should be written to paramName, but I couldn't find any guarantee that option points to a string with length < 17
Interesting that PWM_AUX_DISARMED is 16 bytes long.

Dusted off the Pixhawk1 F450; AUX outputs working, as is the default aux_disarmed parameter. Will do a short flight test next.

[kd0aij]

For future reference, the parameter name length limit of 16 characters is enforced in src/Tools/px4params/srcparser.py

[LorenzMeier]

@kd0aij Any chance you could flash & take this for a short flight?

[kd0aij]

Test flight went OK.

For some reason I had to recalibrate the ESCs before this would fly again, and I ran out of battery after just a minute in the air, but performance in stabilized and altctl with EKF2 was nominal.
I had changed the fmu-v2 config to compile the new logger, but managed to lose the sys_logger parameter change, so no logger was running. Will do a longer flight tomorrow with the new logger.

[LorenzMeier]

Thanks for the baseline testing. Rebased and applied.