Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] CDC/ACM reconnecting when powered from USB power supply #23179

Closed
PetervdPerk-NXP opened this issue May 24, 2024 · 1 comment · Fixed by #23183
Closed

[Bug] CDC/ACM reconnecting when powered from USB power supply #23179

PetervdPerk-NXP opened this issue May 24, 2024 · 1 comment · Fixed by #23183

Comments

@PetervdPerk-NXP
Copy link
Member

PetervdPerk-NXP commented May 24, 2024

Describe the bug

Since the change from #22234 when powering an FMU from a USB power supply you get constant serdis/sercon events.

serdis: Disconnected
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
serdis: Disconnected
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
serdis: Disconnected
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
serdis: Disconnected
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
serdis: Disconnected
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver

Before #22234 this wasn't the case.

To Reproduce

USB power supply (not a PC) connect to FMU.
Then on debug port connect a serial adapter then you observe constant sercon/serdis events.

Software Version

Main

Flight controller

FMU-V6XRT

@AlexKlimaj
Copy link
Member

@dakejahl and I just talked about it. Looks like we just need to differentiate the failed state. One where vbus is present but no computer exists on the other end and one where vbus isn't present. In your case it shouldn't change to the disconnected state but should just stay in the connecting state.

https://github.com/PX4/PX4-Autopilot/pull/22234/files#diff-62140730d7cb3793dfa65e620894497238d929ef6f9450a0bbe0660a08c1a9e5R328-R338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants