Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdcacm_autostart: handle USB with no data lines #23183

Merged
merged 1 commit into from
May 25, 2024

Conversation

dakejahl
Copy link
Contributor

Fixes logic if USB does not have data lines, ie powering the flight controller with USB wall wart. The module will stay in the connecting state and px4_open() will fail silently.

Closes #23179

@AlexKlimaj AlexKlimaj merged commit da35c4a into PX4:main May 25, 2024
82 of 89 checks passed
@PetervdPerk-NXP
Copy link
Member

PetervdPerk-NXP commented Jun 6, 2024

@dagar @davids5
With #22234 being backported to 1.15 now, this fix should also be backported to 1.15

@dk7xe
Copy link
Contributor

dk7xe commented Jun 6, 2024

@dagar @davids5 indeed because that is what happens when i power the FMU from an USB power bank for bench testing after commit d8655fd had been merged into release/1.15

HW arch: PX4_FMU_V6XRT
HW type: V6XRT
HW FMUM ID: 0x000
HW BASE ID: 0x003
PX4 git-hash: d8655fdde9f45ab244f78a991f38fa7f73d86a69
PX4 version: 1.15.0 80 (17760384)
PX4 git-branch: release/1.15
OS: NuttX
OS version: Release 11.0.0 (184549631)
OS git-hash: 6fbb26eb521999844f099ac93974fdc7cc[hardfault_log] Fault Log info File No 4 Length 8205 flags:0x00 state:1
[hardfault_log] Fault Log is Armed
ca6016
Build datetime: Jun  5 2024 22:32:59
Build uri: localhost
Build variant: default
Toolchain: GNU GCC, 9.3.1 20200408 (release)
PX4GUID: 000900000000000000008292807c2c2a800e
MCU: i.MX RT1170 rB0, rev. 0
.................
NuttShell (NSH) NuttX-11.0.0
nsh> sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
WARN  [mavlink] no broadcasting address found
serdis: Disconnected
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
serdis: Disconnected
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
INFO  [gps] u-blox firmware version: SPG 3.01
INFO  [gps] u-blox protocol version: 18.00
INFO  [gps] u-blox module: NEO-M8N-0
serdis: Disconnected
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
serdis: Disconnected
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
serdis: Disconnected
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
serdis: Disconnected
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
serdis: Disconnected
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
serdis: Disconnected
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
serdis: Disconnected
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
serdis: Disconnected
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
serdis: Disconnected
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
serdis: Disconnected
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
serdis: Disconnected
sercon: Registering CDC/ACM serial driver
sercon: Successfully registered the CDC/ACM serial driver
serdis: Disconnected
..... forever

@davids5
Copy link
Member

davids5 commented Jun 6, 2024

@AlexKlimaj Please backport da35c4a as it is need with the other ones you backported

@dakejahl dakejahl deleted the pr-cdcacm_autostart_power_only branch June 11, 2024 05:42
chiara-septentrio pushed a commit to flyingthingsintothings/PX4-Autopilot that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] CDC/ACM reconnecting when powered from USB power supply
5 participants