Navigator: MissionFeasibilityCheck: check if items fit to the current vehicle type #21602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… vehicle type Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
RomanBapst
approved these changes
May 30, 2023
harrisondragoon
pushed a commit
to harrisondragoon/PX4-Autopilot
that referenced
this pull request
May 31, 2023
… vehicle type (PX4#21602) Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
antbre
pushed a commit
to BioMorphic-Intelligence-Lab/PX4-Autopilot
that referenced
this pull request
Sep 14, 2023
… vehicle type (PX4#21602) Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When switching between different vehicle types on the same groundstation, it can happen that by accident a mission that was planned for example for a VTOL gets uploaded to a Multicopter. This is can lead to undesired/unexpected behavior.
Solution
Add
checkItemsFitToVehicleType()check that checks if the vehicle type is non-VTOL but there are VTOL mission items (VTOL_TAKEOFF, VTOL_LAND, VTOL_TRANSITION). The check can later be extended to handle all kind of vehicle type vs mission item checks.Changelog Entry
For release notes: