Fix gz_bridge gets wrong world name when GZ_VERBOSE=1 #21728
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
In simulation, with env. var.
GZ_VERBOSE=1
and a Gazebo world is already running, GZBridge fails to start because it gets the wrong name for the running world. This is because thegrep
command used retrieve only the first occurrence of "/world/.*/clock" and thus, it getsTopic: [@/theotime-Precision-5570:theotime@/world/multicopter/clock]
instead of the real name of the topic/world/multicopter/clock
.Fixes #{21727}
Solution
/world/.*/clock
, which is the caseChangelog Entry
no need
Alternatives
Gazebo's API has a "Name" endpoint for worlds, admittedly it could be cleaner to exploit that. The grep tech could create more issues in the future.
Test coverage
Context
N/A