Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates GZBridge to extract the drone name from a drone in a nested S… #21768

Closed
wants to merge 1 commit into from
Closed

Updates GZBridge to extract the drone name from a drone in a nested S… #21768

wants to merge 1 commit into from

Conversation

hmer101
Copy link

@hmer101 hmer101 commented Jun 27, 2023

Solved Problem

Allows drones in nested SDF models to be flown in gz simulation. This is important if drones are to be connected for multi-drone load carrying and other applications.

Fixes #21767

Solution

  • In GZBridge, extracted the actual drone name from the full nested name.

Changelog Entry

For release notes:

Feature/Bugfix: Allows drones nested in other SDF models to be connected to and flown in gz simulation.
Documentation: Perhaps add clarification to page: https://docs.px4.io/main/en/sim_gazebo_gz/multi_vehicle_simulation.html. 

Alternatives

  • Set GZBridge's _model_name parameter to just be the drone name every time GZBridge is initialized.
  • Update the classes GZMixingInterfaceESC and GZMixingInterfaceServo to work with nested names.

Test coverage

Context

See here for full discussion.

@github-actions github-actions bot added the stale label Jul 28, 2023
@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/multi-tethered-drone-error-matching-flight-task-was-not-able-to-run/32993/5

@github-actions github-actions bot removed the stale label Jul 29, 2023
@hmer101 hmer101 closed this by deleting the head repository Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Nested drone SDFs in Gazebo simulation
3 participants