Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comment in the ModeCompleted.msg #22544

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Conversation

federicociresola
Copy link
Contributor

I added a little comment where a person can see the possible value of nav_state

I added a little comment where a person can see the possible value of nav_state
msg/ModeCompleted.msg Outdated Show resolved Hide resolved
msg/ModeCompleted.msg Outdated Show resolved Hide resolved
hamishwillee
hamishwillee previously approved these changes Dec 20, 2023
Copy link
Contributor

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkueng I'm happy with this, but would also have been happy with just the comment on line 15. Does it make sense to you too?


As an aside, it would help me to discuss at some point what docs are useful generally for topics and update them all at the same time.
It might even be worth adding some tagging for this - @short, @description, @instances (something to indicate whether there can be multiples). Also to decide whether we allow markdown in the comments and so on.

For example, if we allowed something like:

uint8 nav_state                  # Source mode (`VehicleStatus`)

Then I could know VehicleStatus is a message and auto-cross link or similar.
Just a thought.

msg/ModeCompleted.msg Outdated Show resolved Hide resolved
Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might even be worth adding some tagging for this - @short, @description, @instances (something to indicate whether there can be multiples). Also to decide whether we allow markdown in the comments and so on.

I'm all for extending the metadata & docs around that. Ideally we do this in ROS and I started a discussion a while ago, but it did not make it any further.

@bkueng bkueng merged commit 20129e6 into PX4:main Jan 8, 2024
87 checks passed
somebody-once-told-me pushed a commit to somebody-once-told-me/PX4-Autopilot that referenced this pull request Jan 13, 2024
Peize-Liu pushed a commit to Peize-Liu/PX4-Autopilot that referenced this pull request Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants