-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added comment in the ModeCompleted.msg #22544
Conversation
I added a little comment where a person can see the possible value of nav_state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkueng I'm happy with this, but would also have been happy with just the comment on line 15. Does it make sense to you too?
As an aside, it would help me to discuss at some point what docs are useful generally for topics and update them all at the same time.
It might even be worth adding some tagging for this - @short
, @description
, @instances
(something to indicate whether there can be multiples). Also to decide whether we allow markdown in the comments and so on.
For example, if we allowed something like:
uint8 nav_state # Source mode (`VehicleStatus`)
Then I could know VehicleStatus is a message and auto-cross link or similar.
Just a thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might even be worth adding some tagging for this - @short, @description, @instances (something to indicate whether there can be multiples). Also to decide whether we allow markdown in the comments and so on.
I'm all for extending the metadata & docs around that. Ideally we do this in ROS and I started a discussion a while ago, but it did not make it any further.
I added a little comment where a person can see the possible value of nav_state