sd_bench: Display maximum time for maximum write time #22860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
reviewed
Mar 13, 2024
src/systemcmds/sd_bench/sd_bench.cpp
Outdated
| } | ||
|
|
||
| cfg->total_blocks_written = total_blocks; | ||
| PX4_INFO(" Avg : %8.2lf KB/s", (double)block_size * total_blocks / total_elapsed / 1024.); | ||
| PX4_INFO(" maxMWT: %8i ms", max_max_write_time); |
There was a problem hiding this comment.
I would make this more readable, even if it breaks alignment:
Suggested change
| PX4_INFO(" maxMWT: %8i ms", max_max_write_time); | |
| PX4_INFO("Overall max write time: %8i ms", max_max_write_time); |
There was a problem hiding this comment.
Thanks for the suggestion.
I understand about, better not to omit.
The format has been adjusted to match the columns.
With the columns aligned, I removed the numeric format.
muramura
force-pushed
the
PX4_Display_maximum_time_for_maximum_write_time
branch
from
c568f2f
to
630eead
Compare
bkueng
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
Check everything to know the maximum write time max.
I judge a MICRO SD card as good or bad by knowing the max time.
Solution
Show the maximum value of the maximum write time.
Changelog Entry
None
Alternatives
None
Test coverage
None
Context