Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commander: trigger warning when arming denied due to check failure #22885

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

sfuhrer
Copy link
Contributor

@sfuhrer sfuhrer commented Mar 14, 2024

Solved Problem

There is currently no warning/event sent by PX4 when arming is denied due to a preflight check failure (though the preflight field in the top bar is red).

Solution

Add a warning message to make clear that

  1. there was an arming attempt (not that e.g. sticks are not working)
  2. give hint to why arming failed

image

Changelog Entry

For release notes:

Feature: 

Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
@sfuhrer sfuhrer requested a review from bkueng March 14, 2024 09:39
@bkueng bkueng merged commit 6e15dd5 into main Mar 15, 2024
89 of 92 checks passed
@bkueng bkueng deleted the pr-commander-trigger-event-arming-denied-main branch March 15, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants