gps: add flexible GNSS receiver logging for Septentrio receivers #22973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a generic interface over the GPS drivers makes dedicated functionality for each driver harder. Move the Septentrio driver into its own module under the `gnss` driver directory, and let it have its own parameters for only the functionality it requires. This also helps with adding new features because they only need to be implemented for the driver that wants it, simplifying testing.
Add three new parameters that allow users to configure logging on their receiver from their ground control station.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add three new parameters that allow users to configure logging on their receiver from their ground control station.
Solved Problem
If users wanted logging on their GNSS receiver, they had to manually set it up.
Solution
SEP_LOG_HZ,SEP_LOG_LEVELandSEP_LOG_FORCESEP_LOG_HZ: Set the logging frequencySEP_LOG_LEVEL: Set the amount of detail the receiver should logSEP_LOG_FORCE: Set whether any existing logging should be overwrittenChangelog Entry
For release notes:
Alternatives
The alternative was in #22874 which is now closed in favor of this PR on top of the extracted driver.
Test coverage
/
Context
I will keep this as a draft for now for context only. Once the separate driver in #22904 is merged, I will rebase this branch onto main and open it.