Pr param high latency freq #23048
Merged
Pr param high latency freq #23048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
reviewed
Apr 23, 2024
src/modules/mavlink/module.yaml
Outdated
|
|
||
| MAV_${i}_HL_FREQ: | ||
| description: | ||
| short: Configures the frequency of HIGH_LATENCY2 stream for iridium instance ${i} |
There was a problem hiding this comment.
Suggested change
| short: Configures the frequency of HIGH_LATENCY2 stream for iridium instance ${i} | |
| short: Configures the frequency of HIGH_LATENCY2 stream for instance ${i} |
src/modules/mavlink/mavlink_main.cpp
Outdated
| err_flag = true; | ||
|
|
||
| } else { | ||
| if (freq >= 0) { |
There was a problem hiding this comment.
Suggested change
| if (freq >= 0) { | |
| if (freq >= 0.f) { |
oravla5
force-pushed
the
pr-param_high_latency_freq
branch
from
0b80479
to
2b5038c
Compare
bkueng
previously approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
Missing parameter to configure the frequency of the
HIGH_LATENCY2stream iniridiummode.Solution
MAV_${i}_HL_FREQto configureHIGH_LATENCY2stream frequency iniridiummode.mavlink_main.cpp, added parsing of cli option-Fsetting theHIGH_LATENCY2stream frequency iniridiummode.Changelog Entry
For release notes: