navigator: Change multiple decisions to SWITCH statements #23065
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // TODO: handle different frames | ||
| PX4_ERR("Frame type %i not supported", (int)temp_vertex_i.frame); | ||
| break; | ||
| goto loop_exit; |
There was a problem hiding this comment.
Can we please refrain from using goto the break statement was fine here in the if context, just keep the code as is if you ask me.
There was a problem hiding this comment.
@PetervdPerk-NXP san.
The break in the if statement exits the for statement.
A break in a switch statement exits from a switch statement.
Before the change, the GOTO statement was used because it is a break to exit from the for statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
Comparing the same variable value to multiple decision values.
Solution
Change to SWITCH statement.
Changelog Entry
None
Alternatives
None
Test coverage
None
Context
None