Airspeed plot disappeared for PX4 v1.10 (and earlier)

[ThomasRigi]

Recently the plot for airspeed / groundspeed has disappeared on flightlogs using PX4 v1.10.2 and older. Here's a sample SITL log (flown with Gazebo's standard VTOL on v1.10.2) :
https://logs.px4.io/plot_app?log=7ea35ca1-e508-40c1-85be-5497b472b978

I believe it is this commit that introduced changes on which airspeed topic is plotted: bda9fc9
But I don't understand why it doesn't work. L343-346 should keep the compatibility I'd thought.

@jinchengde @bkueng can you look into this please? Thanks :)

[jinchengde]

It looks like there is no "airspeed validated" topic in old version of log and crashed

[ThomasRigi]

To my knowledge the "airspeed validated" topic only got introduced after v1.10.

When there is no "airspeed validated" topic, shouldn't the if clause at

flight_review/plot_app/configured_plots.py

Line 334 in eaad23c

if ulog.get_dataset('airspeed_validated') is not None:

trigger the else clause at

flight_review/plot_app/configured_plots.py

Lines 343 to 346 in eaad23c

	else:
	data_plot.change_dataset('airspeed')
	data_plot.add_graph(['indicated_airspeed_m_s'], colors8[1:2],
	['Indicated Airspeed'])

? The "airspeed" topic is present in the old version. Still, there is no plot shown.

Edit: only seen after sending my comment that you have already opened a PR for this. Thanks!

[jinchengde]

@ThomasRigi thanks to figure out this issue

[George-avy]

Hi! For some reason this fix doesn't work for me.
Even though my log contains the new airspeed_validated topic, indicated_airspeed is plotted, instead of equivalent_airspeed.
Weird...

Log:https://logs.px4.io/plot_app?log=4576ddfd-4cd4-4c63-a6b4-77df451bcc54#Nav-Airspeed

[bkueng]

Yeah the check was simply incorrect. Fixed in 8112a22.

[George-avy]

Ah, nice. Thanks!