Add tecs alt setpoint and remove thrust #199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added tecs alt setpoint for better analysis. there is not need to display thrust in this graph, also thrust scale is different with altitude scale.
bkueng
requested changes
Aug 7, 2020
| @@ -269,9 +269,9 @@ def generate_plots(ulog, px4_ulog, db_data, vehicle_data): | |||
| data_plot.change_dataset('position_setpoint_triplet') | |||
| data_plot.add_circle(['current.alt'], [plot_config['mission_setpoint_color']], | |||
| ['Altitude Setpoint']) | |||
| data_plot.change_dataset('actuator_controls_0') | |||
There was a problem hiding this comment.
Please do not remove existing data w/o good reason. It's generally useful for MC's.
To improve the plot regarding the offset difference, you could add the minimum baro altitude (rounded down to the next lower 100) as an offset to the thrust. Then everything is in a similar range.
| data_plot.add_graph([lambda data: ('thrust', data['control[3]']*100)], | ||
| colors8[6:7], ['Thrust [0, 100]']) | ||
| data_plot.change_dataset('tecs_status') | ||
| data_plot.add_graph(['altitude_sp'], colors8[3:4], ['Tecs Altitude Setpoint']) |
There was a problem hiding this comment.
Suggested change
| data_plot.add_graph(['altitude_sp'], colors8[3:4], ['Tecs Altitude Setpoint']) | |
| data_plot.add_graph(['altitude_sp'], colors8[3:4], ['TECS Altitude Setpoint']) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added tecs alt setpoint for better analysis.
there is not need to display thrust in this graph, also thrust scale is different with altitude scale.