Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Random Greeting API Endpoint (Back-End) #1

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

PabloBona
Copy link
Owner

@PabloBona PabloBona commented Oct 25, 2023

This pull request addresses the following requirements for the Hello Rails Back-End project:

📖 Hello Rails Back-End

Hello Rails Back-End is a Rails API app that provides random greetings through an API endpoint. This project meets the following requirements:

🛠 Project Requirements

  • Create a Rails API app called 'hello-rails-back-end'.

    • The Rails API application has been successfully created and named 'hello-rails-back-end'.
  • Initialize the project with Git.

    • The project has been initialized with Git, and the initial commit has been made.
  • Set up a Postgres database and create a table for storing messages.

    • A Postgres database has been set up, and a 'messages' table has been created to store greetings.
  • Populate the table with 5 different greetings.

    • The 'messages' table has been populated with 5 distinct greetings for variety.
  • Create an API endpoint that selects a random greeting from the table.

    • An API endpoint, accessible at /api/greetings/random, has been implemented to select and return a random greeting from the 'messages' table.

    This back-end application is designed to work in conjunction with the Hello Rails Front-End project.
    This is the PR for the Front-end

@PabloBona PabloBona changed the title Feature: Implement Random Greeting API Endpoint Implement Random Greeting API Endpoint Oct 25, 2023
@PabloBona PabloBona changed the title Implement Random Greeting API Endpoint Implement Random Greeting API Endpoint (Back-End) Oct 25, 2023
Copy link

@cynthiainga cynthiainga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PabloBona,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • The route is created ✔️
  • Controller with one action is created ✔️
  • Correct Gitflow ✔️
  • No linters errors ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were missed by the previous reviewer and addressing them will really improve your application.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants