Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Definitions for Redirected Entries #59

Closed
kumar-ish opened this issue Jul 10, 2023 · 2 comments
Closed

Add Definitions for Redirected Entries #59

kumar-ish opened this issue Jul 10, 2023 · 2 comments

Comments

@kumar-ish
Copy link

kumar-ish commented Jul 10, 2023

[Cross-posting from the Zhongwen github repo so the UI for the popup is different, but I've started using zhongzhong now and the same thing occurs in the zhongzohong UI]

Hi. Occasionally I come across a definition like "嘴硬心軟" (see screenshot) which just redirects to another definition through the extension. I think it would be good to show the redirected definition (perhaps indented under the suggestion to redirect) instead of having to manually find it on another website / on CEDICT. Perhaps this can be optionally enabled as an experiment on one of the extension options, just in case there's any edge cases that we don't consider. I'm happy to code this up and go through the review process as you see fit.

image
@PabloRomanH
Copy link
Owner

PabloRomanH commented Jul 10, 2023 via email

@kumar-ish
Copy link
Author

I was being silly, sorry 😓 -- I didn't notice the redirected definition at the bottom. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants