Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jog flushing on cancel #657

Merged
merged 5 commits into from
Mar 3, 2024
Merged

Fix jog flushing on cancel #657

merged 5 commits into from
Mar 3, 2024

Conversation

Paciente8159
Copy link
Owner

  • fixes jog flushing bug when a jog cancel is issued and jog commands are still in the serial stream waiting to be processed
  • modifies behavior of jog cancel. All unprocessed jog commands still in the stream will be flushed with error message
  • modifies on command error behavior. On an error the motion waits completion and all systems are synched to prevent mismatches.

@Paciente8159 Paciente8159 added bug Something isn't working needs: testing needs: testing core: motion control core: motion control, planning and interpolation core: parser core: command and gcode parsing labels Mar 2, 2024
@Paciente8159
reset defaults
899a5c8 
- reset config defaults
- forced inputs read on main loop and modified io control vars to volatile
- fhold input now calls hold rt cmd function
- discard command on jog command error to prevent later execution
@Paciente8159
cycle start resume button is now click once
c72d074
@Paciente8159
fixed interpolator accelerations calculations
4e97d0a 
- fixed interpolator accelerations calculations by preventing time slices that are too small leading to super slow accelerations and deaccelerations
@Paciente8159 Paciente8159 added tested: OK tested: OK and ready to integrate and removed needs: testing needs: testing labels Mar 3, 2024
@Paciente8159 Paciente8159 merged commit 637b0a7 into master Mar 3, 2024
38 checks passed
@Paciente8159 Paciente8159 deleted the fix-jog-flushing-on-cancel branch March 3, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working core: motion control core: motion control, planning and interpolation core: parser core: command and gcode parsing tested: OK tested: OK and ready to integrate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Paciente8159