Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some filters flatten country highlighting #43

Closed
mrjones-plip opened this issue Dec 1, 2016 · 1 comment
Closed

some filters flatten country highlighting #43

mrjones-plip opened this issue Dec 1, 2016 · 1 comment
Labels

Comments

@mrjones-plip
Copy link
Contributor

on some filters the country's colors all become the same instead of having the correct, discrete values.

steps to reproduce:

  1. go to PCH's IXP Dir: https:/pch.net/ixp
  2. add a filter "PCH Present: Yes"

expected: countries colors remain accurate based on defined map.countries.attr.fill.transform() and values of remaining countries after the filter
actual: countries all become the same gray color
note 1: choosing "No" seems to work as expected
note 2: if this is a bug in PCH's implementation - please call us out, we don't want to bother y'all if it's endemic to our site!

@mrjones-plip mrjones-plip changed the title some filters flatten country highliting some filters flatten country highlighting Dec 1, 2016
@mrjones-plip
Copy link
Contributor Author

Here's before:
before pch ixp

And here's after:
after pch ixp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant