Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the way colors work in heatmap #56

Closed
mrjones-plip opened this issue Jan 23, 2017 · 3 comments
Closed

change the way colors work in heatmap #56

mrjones-plip opened this issue Jan 23, 2017 · 3 comments

Comments

@mrjones-plip
Copy link
Contributor

In a heatmap, right now, if you specify a color like this: heatmap.circles.color = '#043864' the starting color (area with most overlaps) ends up being not #043864, but instead it is lighter. As well, on the way from the darkest color to white, maptable chooses it's own transition colors used in the gradient. You should be able to specify which colors it transitions through. Specifically, PCH would like a way for the darkest color on any heatmap to always start at heatmap.circles.colorand for the colors on the way to white be the ones we use in our palette. Currently we define our palette with a min an max which works great on the choropleth maps like this one. We'd like the same for the heatmap.

@mrjones-plip
Copy link
Contributor Author

@melalj - looking really close! The colors do fall off accurately I think, matching what I'd expect to see. The darkest color in Europe doesn't quite match the darkest color (aka 100%) in our existing percentile based choropleth map (see US).

@melalj
Copy link
Member

melalj commented Mar 3, 2017

We Should not close the issue, before it the PR is closed and merged to master ;)
I added comments on the PR

@melalj melalj reopened this Mar 3, 2017
@mrjones-plip
Copy link
Contributor Author

looks good - thanks @melalj also - didn't mean to close the issue last time, thanks for re-opening.

mrjones-plip pushed a commit that referenced this issue Mar 20, 2017
changed the way colors work in heatmap #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants