Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added colorStrength heatmap parameter #60

Merged
merged 5 commits into from
Apr 5, 2017
Merged

added colorStrength heatmap parameter #60

merged 5 commits into from
Apr 5, 2017

Conversation

melalj
Copy link
Member

@melalj melalj commented Mar 2, 2017

No description provided.

@melalj melalj requested a review from mrjones-plip March 2, 2017 17:16
@melalj
Copy link
Member Author

melalj commented Mar 2, 2017

Related to #58

@mrjones-plip
Copy link
Contributor

mrjones-plip commented Mar 2, 2017

k - cool, to answer #58's question, "what's the best way to tweak the fall off of a data point? " you added colorStrength, gotcha. I loaded up dev-58 branch and played with the value. Setting it to 0 and I still saw colors - I would have expected none. Setting it to 1000 I would have expected it to cover the globe, but it only goes about say...45 degrees or so. The difference between 1 and 0.5 seems too small as well.

Either way - be sure to update README.md. I may actually be using it wrong as I don't know what the readme would say ;)

@melalj
Copy link
Member Author

melalj commented Mar 3, 2017

@Ths2-9Y-LqJt6 I just updated the behavior to make it easier to configure

  • heatmap.colorStrength: (float, default: 1) Adjusts heatmap color strength, (0 make things transparent, 1 normal behavior, > 1 to make the color darker)

@mrjones-plip mrjones-plip changed the title added fallOutStrenght heatmap parameter added fallOffStrenght heatmap parameter Mar 20, 2017
@mrjones-plip mrjones-plip changed the title added fallOffStrenght heatmap parameter added colorStrength heatmap parameter Mar 20, 2017
@mrjones-plip
Copy link
Contributor

i had to merge master to dev-58 to get it to compile. testing colorStrength does not do anything. values of 0,1 or 10 load the same map. maybe commits from PR #56 broke this PR?

@melalj melalj changed the base branch from dev-56 to master April 5, 2017 09:43
@melalj
Copy link
Member Author

melalj commented Apr 5, 2017

@Ths2-9Y-LqJt6 Since you merged dev-56 to master, I set the base branch for this PR as master.
That's surprising, I just launched the /heatmap.html example and colorStrenght seems to have an effect:

screen shot 2017-04-05 at 4 48 09 pm

@mrjones-plip
Copy link
Contributor

@melalj - agreed - it does work! I must have not pulled latest code. Thanks very for re-testing and sending along the screen shot of the different values for me to easily test against.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants