-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added "!insult" command #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean, my only request is a possible name change for this. Some suggestions/ideas abuse
, taunt
, offend
? I suppose the term insult could seem a bit harsh and maybe we should take a lighter approach here, I'm leaning more towards, taunt
.
Also, if you could amend your commit message to remove feat:
. This is simply my OCD at play here. I think it looks a bit cleaner, basically, all my commits follow this style. I am aware agro's do not but I plan on asking him to follow in future as well.
@@ -0,0 +1,61 @@ | |||
Just what do you think you're doing Dave? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These insults are terrible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can always edit it though.
Due to lack of better insults, I am cancelling the PR. Will submit again after I find a good list of insults. |
So as we discussed on discord, feature functionality could be something similar to the following.
Add a table to migrations, and use |
Consider this schema, extend upon this or simply add it to migrations.
|
Instead of a file to hold insults, DB will be used from now on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you mentioned, the addition of an insulting message is not capped, thus allowing the full 2k message limit of discord to be used. A max length of 500 for insulting messages should suffice.
apophis/cmds/insult.py
Outdated
@@ -9,6 +9,7 @@ | |||
!insult add a new insult | |||
!insult del <integer> | |||
```""" | |||
limit = 500 # Not more than 500 characters insult |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should declare this as a constant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
This command will pick a random insult, and send on the channel. You can
also select the person to insult too.
Example: