Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NNAdapter][CambriconMLU] Add CambriconMLU driver HAL #6947

Merged

Conversation

Danielmic
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 15, 2021

CLA assistant check
All committers have signed the CLA.

@paddle-bot-old
Copy link

Thanks for your contribution!

cmake/lite.cmake Outdated Show resolved Hide resolved
cmake/lite.cmake Outdated Show resolved Hide resolved
cmake/lite.cmake Outdated Show resolved Hide resolved
tools/ci_tools/ci_nn_accelerators_unit_test.sh Outdated Show resolved Hide resolved
@Danielmic Danielmic force-pushed the miaochen/add_cambricon_driver_hal branch 3 times, most recently from 04c34c4 to 01abe8a Compare September 15, 2021 13:19
@Danielmic Danielmic force-pushed the miaochen/add_cambricon_driver_hal branch 2 times, most recently from 88d097a to 709f3a2 Compare September 16, 2021 10:11
hong19860320
hong19860320 previously approved these changes Sep 16, 2021
Copy link
Collaborator

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Danielmic Danielmic force-pushed the miaochen/add_cambricon_driver_hal branch from 7c4e32b to 40511ed Compare September 17, 2021 02:49
@Danielmic Danielmic force-pushed the miaochen/add_cambricon_driver_hal branch 5 times, most recently from a53487a to 010e40c Compare October 14, 2021 14:00
zhupengyang
zhupengyang previously approved these changes Oct 15, 2021
Copy link
Collaborator

@zhupengyang zhupengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

格式需要修改下吧,格式检查的CI没过

lite/tools/build_linux.sh Outdated Show resolved Hide resolved
lite/tests/kernels/split_test.cc Outdated Show resolved Hide resolved
switch (fuse_code) {
case NNADAPTER_FUSED_RELU:
{
auto activation_node = converter->network()->AddIActivationNode(output_tensor, magicmind::IActivation::RELU);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上,或者考虑抽取出来作为一个公共的函数

@Danielmic Danielmic force-pushed the miaochen/add_cambricon_driver_hal branch from a8a1da5 to 22e863d Compare October 19, 2021 11:54
@Danielmic Danielmic force-pushed the miaochen/add_cambricon_driver_hal branch 3 times, most recently from ff0e03a to fb2759a Compare November 2, 2021 06:13
@Danielmic Danielmic force-pushed the miaochen/add_cambricon_driver_hal branch from fb2759a to 72537ad Compare November 4, 2021 07:40
@Danielmic Danielmic force-pushed the miaochen/add_cambricon_driver_hal branch from 72537ad to bd9b67d Compare November 4, 2021 08:47
Copy link
Collaborator

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lite/tests/kernels/split_test.cc Show resolved Hide resolved
@hong19860320 hong19860320 merged commit 1ae2532 into PaddlePaddle:develop Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants