Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paddle GRU step layer does not support error clipping #1891

Closed
reyoung opened this issue Apr 25, 2017 · 1 comment
Closed

Paddle GRU step layer does not support error clipping #1891

reyoung opened this issue Apr 25, 2017 · 1 comment
Assignees
@reyoung

Comments

@reyoung
Copy link
Collaborator

reyoung commented Apr 25, 2017

In trainer_config_helper, we didn't compose a naive implementation of GRU step layer, which supports error clipping.

Error clipping in GRU step is very useful, especially for long sequence problems, such as machine translation.

If we support error clipping in gru step, it will fix issue #1143 .
@reyoung reyoung self-assigned this Apr 25, 2017
@reyoung reyoung mentioned this issue Apr 25, 2017
Closed
@reyoung reyoung mentioned this issue Apr 25, 2017
Merged
reyoung added a commit to reyoung/Paddle that referenced this issue Apr 25, 2017
@reyoung
Add error clipping to MT demo.
f5a4a16 
* Compose GRU step naive layer in trainer config helpers.
  * It is uses mixed_layer for gate.
  * It supports ERROR_CLIPPING, DROPOUT
* Add error clipping in MT demo.
* Fix PaddlePaddle#1143
* Fix PaddlePaddle#1891
@qingqing01 qingqing01 mentioned this issue Apr 25, 2017
Closed
reyoung added a commit to reyoung/Paddle that referenced this issue Apr 26, 2017
@reyoung
Add error clipping to MT demo.
3f1151a 
* Compose GRU step naive layer in trainer config helpers.
  * It is uses mixed_layer for gate.
  * It supports ERROR_CLIPPING, DROPOUT
* Add error clipping in MT demo.
* Fix PaddlePaddle#1143
* Fix PaddlePaddle#1891
@reyoung
Copy link
Collaborator Author

reyoung commented Apr 26, 2017

Fix by #1893

@reyoung reyoung closed this as completed Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reyoung reyoung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reyoung