Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error clipping to MT demo. #1893

Merged

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Apr 25, 2017

@reyoung reyoung requested a review from QiJune April 25, 2017 12:19
@reyoung reyoung force-pushed the Add_error_clipping_to_mt_demo branch 2 times, most recently from 408816c to 4f1cf22 Compare April 25, 2017 12:40
@wrap_act_default(act=TanhActivation())
@wrap_name_default('gru_step')
@layer_support(ERROR_CLIPPING, DROPOUT)
def gru_step_naive_layer(input,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically translate from here

* Compose GRU step naive layer in trainer config helpers.
  * It is uses mixed_layer for gate.
  * It supports ERROR_CLIPPING, DROPOUT
* Add error clipping in MT demo.
* Fix PaddlePaddle#1143
* Fix PaddlePaddle#1891
@reyoung reyoung force-pushed the Add_error_clipping_to_mt_demo branch from 4f1cf22 to c6a8e23 Compare April 26, 2017 02:40
Copy link
Member

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyoung reyoung merged commit ddc2c6e into PaddlePaddle:release/0.10.0 Apr 26, 2017
@reyoung reyoung deleted the Add_error_clipping_to_mt_demo branch April 26, 2017 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants