Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the sources in utils directory #956

Closed
6 of 35 tasks
gangliao opened this issue Dec 20, 2016 · 3 comments
Closed
6 of 35 tasks

Refine the sources in utils directory #956

gangliao opened this issue Dec 20, 2016 · 3 comments
Assignees

Comments

@gangliao
Copy link
Contributor

gangliao commented Dec 20, 2016

Currently, paddle/utils includes miscellaneous, irrelevant source code, which should be deleted or moved to other places.

For instance, dependency relationships:

[utils <- cuda], [cuda <- utils]
initMain() in utils dir depends on hl_start() in cuda dir, and vice versa .

After discussing with @reyoung @wangkuiyi, we reached a preliminary consensus to revise sources.

  • ├── BarrierStat.cpp
  • ├── BarrierStat.h
  • ├── CMakeLists.txt
  • ├── ClassRegistrar.h
  • ├── CommandLineParser.cpp Remove utils/CommandLineParser.h #989 @gangliao
  • ├── CommandLineParser.h Remove utils/CommandLineParser.h #989 @gangliao
  • ├── CpuId.cpp runtime check flags for AVX @gangliao
  • ├── CpuId.h @gangliao
  • ├── CustomStackTrace.cpp
  • ├── CustomStackTrace.h
  • ├── DisableCopy.h Add common.h and remove DisableCopy and TypeDefs #994 move into common.h @gangliao
  • ├── Excepts.cpp mac_os_x Move Execepts into arch/osx dir #1075 @gangliao
  • ├── Excepts.h @gangliao
  • ├── Flags.cpp Remove all global variables in Paddle #852 @reyoung
  • ├── Flags.h @reyoung all global flags definitions, need to be removed.
  • ├── GlobalConstants.cpp we do new API implementation. PassType -> Trainer.h,
  • ├── GlobalConstants.h ParameterType -> Parameter.h
  • ├── Locks.h some locks can be removed.
  • ├── Logging.cpp use gflags.h, Keep debug logging level
  • ├── Logging.h
  • ├── PythonUtil.cpp /paddle/python
  • ├── PythonUtil.h
  • ├── Queue.h ThreadSafeQueue.h
  • ├── Stat.cpp move registerTimer to paddle/stats
  • ├── Stat.h
  • ├── StringUtil.cpp
  • ├── StringUtil.h
  • ├── Thread.h delete if not necessary
  • ├── ThreadLocal.cpp seems necessary, how about c++11 thread library?
  • ├── ThreadLocal.h
  • ├── TypeDefs.h FloatType.h Add common.h and remove DisableCopy and TypeDefs #994 move into common.h @gangliao
  • ├── Util.cpp
  • ├── Util.h split into several pieces
  • ├── Version.cpp delete or split
  • ├── Version.h
    ├── arch
    │ ├── linux
    │ │ └── Locks.cpp
    │ └── osx
    │ └── Locks.cpp
    ├── enable_virtualenv.c
    ├── enable_virtualenv.py
    └── tests
@gangliao gangliao self-assigned this Dec 20, 2016
@wangkuiyi
Copy link
Collaborator

Good to see this issue! Are we going to create some sub-tasks and assign them to our team members? Thansk! @gangliao

@gangliao
Copy link
Contributor Author

@wangkuiyi
Firstly, I will do a typical sub-task fully based on our c++ style, discussing with our colleagues who want to involve and contribute.

The continued follow-up development works and even the future C API will benefit a lot from this start point.

Thanks a lot.

@gangliao
Copy link
Contributor Author

gangliao commented Dec 21, 2016

For DisableCopy.h, it might be moved into common.h

zhhsplendid pushed a commit to zhhsplendid/Paddle that referenced this issue Sep 25, 2019
wangxicoding pushed a commit to wangxicoding/Paddle that referenced this issue Dec 9, 2021
* fix write file

* add share folder support

* don't delete train log

* don't use inplace random mask.

Co-authored-by: Zeyu Chen <chenzeyu01@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants