Remove utils/CommandLineParser.h #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 tasks
reyoung
reviewed
Dec 22, 2016
| @@ -152,7 +152,7 @@ void initMain(int argc, char** argv) { | |||
| line += ' '; | |||
| } | |||
| LOG(INFO) << "commandline: " << line; | |||
| ParseCommandLineFlags(&argc, argv, true); | |||
| gflags::ParseCommandLineFlags(&argc, &argv, true); | |||
There was a problem hiding this comment.
有个bug，gflags的namespace不一定是gflags。
gflags的不同版本里面有区别。这个namespace有的时候是google，有的时候是gflags
paddle/utils/CommandLineParser.cpp 这里有对namespace的特殊性进行处理。。
不过，如果我们依赖确定某个版本的gflags就没这个问题了。。。
There was a problem hiding this comment.
我之前也check了一下，应该是老版有这个问题
Line 159 in 46bd5f5
gangliao
commented
Dec 22, 2016
| @@ -152,6 +152,11 @@ void initMain(int argc, char** argv) { | |||
| line += ' '; | |||
| } | |||
| LOG(INFO) << "commandline: " << line; | |||
|
|
|||
| #ifndef GFLAGS_GFLAGS_H_ | |||
reyoung
approved these changes
Dec 22, 2016
| @@ -152,6 +152,11 @@ void initMain(int argc, char** argv) { | |||
| line += ' '; | |||
| } | |||
| LOG(INFO) << "commandline: " << line; | |||
|
|
|||
| #ifndef GFLAGS_GFLAGS_H_ | |||
wangxicoding
pushed a commit
to wangxicoding/Paddle
that referenced
this pull request
Dec 9, 2021
* add bart * add unimo * add roberta * add roformer * modify transformer-rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#956
Follow C++ style: https://github.com/PaddlePaddle/cpp-primer-digest/blame/master/README.md#L63