add usage collection for demo #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `paddle usage` command to support collecting demo usage.
|
跟 @reyoung 讨论后，没有完全的采用 #965 中设计的方案。区别在于：
除了原始的脚本 paddle/scripts/tools/usage_stat/feedback.sh 之外，另外：
|
wangkuiyi
reviewed
Dec 28, 2016
| @@ -122,6 +122,9 @@ case "$1" in | |||
| "make_diagram") | |||
| python -m paddle.utils.make_model_diagram ${@:2} | |||
| ;; | |||
| "usage") | |||
| $MYDIR/../opt/paddle/bin/paddle_feedback ${@:2} | |||
There was a problem hiding this comment.
是不是paddle_feedback 改名叫 paddle_usage，或者 paddle usage 这个命令改名叫 paddle feedback ？我自己感觉前者意思更明确一些？
There was a problem hiding this comment.
说得对，那我统一改成usage吧。这个是前后开发时间太长导致的命名不一致...
wangkuiyi
reviewed
Dec 28, 2016
| @@ -0,0 +1,172 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
feedback.sh ==> usage.sh ?
added 2 commits
December 28, 2016 21:14
|
请 @wangkuiyi 或 @reyoung 帮忙review一下，谢谢~ |
wangkuiyi
approved these changes
Jan 1, 2017
added 5 commits
January 3, 2017 11:33
wangxicoding
pushed a commit
to wangxicoding/Paddle
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
paddle usagecommand to support collecting demo usage.resolve #965