Update trainer api #10653
Closed
Update trainer api #10653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… update-trainer-api
daming-lu
approved these changes
May 15, 2018
| # trainer.save_params(save_dirname) | ||
| # https://github.com/PaddlePaddle/Paddle/pull/10445 | ||
| trainer.save_inference_model(save_dirname) | ||
| trainer.save_params(save_dirname) |
There was a problem hiding this comment.
I noticed we switched from trainer.save_inference_model(save_dirname) back to trainer.save_params(save_dirname). What is the diff between them? We discussed this here. To me save_inference_model looks more reasonable.
There was a problem hiding this comment.
#10648
@wangkuiyi Think that we only need to save parameters and do not need to save inference program, inference program should be provided by a Python function.
| @@ -108,10 +99,11 @@ def event_handler(event): | |||
| feed_order=['img', 'label']) | |||
There was a problem hiding this comment.
test_recognize_digits_conv fails on this line.
Merged
|
copy and merged by #10674 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #10648