Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update trainer api #10674

Merged
merged 11 commits into from
May 16, 2018
Merged

Update trainer api #10674

merged 11 commits into from
May 16, 2018

Conversation

daming-lu
Copy link
Contributor

@daming-lu daming-lu commented May 15, 2018 •
edited

This PR is the same as Longfei's PR here. Just need to add fix test failure commit to fix the test

@daming-lu daming-lu mentioned this pull request May 16, 2018
Closed
jacquesqiao
jacquesqiao approved these changes May 16, 2018
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daming-lu daming-lu merged commit 74ca73b into PaddlePaddle:develop May 16, 2018
@daming-lu daming-lu deleted the update-trainer-api branch May 16, 2018 00:19
@jacquesqiao jacquesqiao mentioned this pull request May 16, 2018
Closed
@sidgoyal78 sidgoyal78 mentioned this pull request May 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesqiao jacquesqiao jacquesqiao approved these changes

@tonyyang-svail tonyyang-svail Awaiting requested review from tonyyang-svail

@sidgoyal78 sidgoyal78 Awaiting requested review from sidgoyal78

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daming-lu @jacquesqiao