Refine the generation process of swig's python wrapper #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gangliao
commented
Jan 10, 2017
cmake/util.cmake
Outdated
| @@ -95,32 +95,12 @@ function(link_paddle_exe TARGET_NAME) | |||
| paddle_parameter | |||
| paddle_proto | |||
| paddle_cuda | |||
| ${METRIC_LIBS} | |||
reyoung
requested changes
Jan 11, 2017
paddle/api/CMakeLists.txt
Outdated
| ${RDMA_LD_FLAGS} | ||
| ${RDMA_LIBS} | ||
| ${START_END} | ||
| ) | ||
|
|
There was a problem hiding this comment.
# TODO(yuyang18) : make wheel name calculated by cmake
这个事情其实还是没有fix
paddle/api/CMakeLists.txt
Outdated
| ) | ||
|
|
||
| generate_python_api(python_swig_sources) | ||
| IF(APPLE) | ||
| SET(ARCHIVE_START "-undefined dynamic_lookup -Wl,-all_load") |
There was a problem hiding this comment.
记得 -all_load 不太等于ARCHIVE_START...
paddle/api/CMakeLists.txt
Outdated
| add_custom_command(OUTPUT ${PROJ_ROOT}/paddle/dist/.timestamp | ||
| COMMAND mv ${CMAKE_CURRENT_BINARY_DIR}/swig_paddle.py ${PROJ_ROOT}/paddle/py_paddle |
There was a problem hiding this comment.
这个可以重新搞一下。
1、应该用cp而不是用 mv，否则，${CMAKE_CURRENT_BINARY_DIR}/swig_paddle.py 会永远不存在，然后每次make的时候都会编译。
2、之前用timestamp来标记这个OUTPUT其实是个trick
- 理论上应该output的是那个wheel包的名字，但是python的wheel包的名字是运行时算出来的，就没在cmake里面搞。
- 现在既然有复制的过程。可以直接用_swig_paddle.so作为输出之类的。
paddle/api/CMakeLists.txt
Outdated
| else() | ||
| set(GFLAGS_LOCATION ${GFLAGS_LIBRARIES}) | ||
| endif() | ||
| FILE(GLOB PY_PADDLE_PYTHON_FILES ${PROJ_ROOT}/paddle/py_paddle/*.py) |
There was a problem hiding this comment.
GLOB => GLOB_RECURSE
因为我们可能会在这个包里面加一些其他的子目录，子目录下面也有PY文件。
There was a problem hiding this comment.
删掉了 好像这里没起什么作用 以后新增的py,直接在https://github.com/PaddlePaddle/Paddle/pull/1099/files#diff-409abc2eda4ed1dba2c69defc807748dR22 里面加，直观一些。
|
@reyoung done |
update branch swig.so
wangxicoding
pushed a commit
to wangxicoding/Paddle
that referenced
this pull request
Dec 9, 2021
* modify transforner-rst * modify electra tokenizer * modify electramodel * modify electra criterion * modify models * modify tokenizers * fix errors * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1083