Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish Non-Layer API #11531

Merged
merged 10 commits into from
Jun 20, 2018
Merged

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Jun 17, 2018

No description provided.

Change the global/default scope instance by Python `with` statement. All
variable in runtime will assigned to the new scope.

Examples:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use

.. code-block:: python

for examples?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only >>> style is used in the examples of napoleon.

:code:`fluid.Trainer`. Used to configuration how to save checkpoint.

Args:
checkpoint_dir(str): Directory path to save check point. Default is the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

epoch_id(int): The current epoch ID.
step_id(int): The current step ID.
metrics(list): A list of fetched tensor. The order of this list is same
as the :code:`train_func` returns.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jacquesqiao
Copy link
Member

jacquesqiao commented Jun 19, 2018

似乎没找到
Program
default_main_program
default_startup_program
program_guard

@@ -316,7 +426,14 @@ def test(self, reader, feed_order):
self.train_func_outputs)

def save_params(self, param_path):
# reference: save_persistables in io.py
"""
Save all parameters into :code:`param_path`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Args:
param_path(str): The path to save parameters

Returns:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
没有参数类型

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -58,6 +97,13 @@ def convert_reader_to_recordio_files(
compressor=core.RecordIOWriter.Compressor.Snappy,
max_num_records=1000,
feed_order=None):
"""
convert a python reader to many recordio files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有参数列表

Copy link
Collaborator Author

@reyoung reyoung Jun 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个函数和 convert_reader_to_recordio_file 基本一样。 我加个超链接吧。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jacquesqiao
Copy link
Member

模块不在网站上
release_memory
convert_reader_to_recordio_file
convert_reader_to_recordio_files

@jacquesqiao
Copy link
Member

jacquesqiao commented Jun 20, 2018

1. convert_reader_to_recordio_files没有参数列表

image

2. Trainer.test() 没有参数类型。

image

Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@reyoung reyoung merged commit b94f784 into PaddlePaddle:develop Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants