Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNNL] 3D Fully-Connected #21746

Merged
merged 10 commits into from
Jan 3, 2020
Merged

[DNNL] 3D Fully-Connected #21746

merged 10 commits into from
Jan 3, 2020

Conversation

Sand3r-
Copy link
Contributor

@Sand3r- Sand3r- commented Dec 13, 2019

Introduces support for 3D FC in both fp32 and int8.

@Sand3r- Sand3r- requested a review from wojtuss December 13, 2019 14:38
@luotao1 luotao1 added the Intel label Dec 13, 2019
@wojtuss wojtuss mentioned this pull request Dec 15, 2019
Open
@Sand3r- Sand3r- requested a review from luotao1 December 18, 2019 08:12
@luotao1 luotao1 requested a review from wzzju December 18, 2019 08:39
wojtuss
wojtuss previously approved these changes Dec 18, 2019
View reviewed changes
Copy link

@wojtuss wojtuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sand3r-
Copy link
Contributor Author

Sand3r- commented Dec 19, 2019

@wzzju Could you please start the review?

wzzju
wzzju previously approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@wzzju wzzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

fix FC weights padding
139e861 
test=develop
@wojtuss wojtuss dismissed stale reviews from wzzju and themself via 139e861 December 20, 2019 21:01
wozna
wozna approved these changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@wozna wozna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jczaja
jczaja approved these changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

luotao1
luotao1 approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 6192108 into PaddlePaddle:develop Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@jczaja jczaja jczaja approved these changes

@wozna wozna wozna approved these changes

@wzzju wzzju wzzju left review comments

@wojtuss wojtuss wojtuss left review comments

Assignees
No one assigned
Labels
Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Sand3r- @luotao1 @jczaja @wzzju @wojtuss @wozna