Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Norm op error #26771

Merged
merged 13 commits into from
Sep 8, 2020
Merged

fix Norm op error #26771

merged 13 commits into from
Sep 8, 2020

Conversation

yongqiangma
Copy link
Contributor

@yongqiangma yongqiangma commented Aug 28, 2020

PR types

Bug fixes

PR changes

ops

Describe

1、 fix frobenius_norm error when 2-axis;
2、support 1-axis for frobenius_norm, (use p=2 and 1-axis to compute)
3、rm p=0 and 2-axis support.

image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@yongqiangma yongqiangma changed the title Norm fix Norm en doc Aug 28, 2020
zhupengyang
zhupengyang previously approved these changes Aug 28, 2020
@yongqiangma yongqiangma changed the title fix Norm en doc fix Norm op error Sep 8, 2020
Copy link
Contributor

@zhupengyang zhupengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yongqiangma yongqiangma merged commit 4558d39 into PaddlePaddle:develop Sep 8, 2020
yongqiangma added a commit to yongqiangma/Paddle that referenced this pull request Sep 8, 2020
* fix frobenius_norm error, rm p=0 2-axis support. test=develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants