Add correlation api to contrib #27015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
qingqing01
reviewed
Sep 7, 2020
| void Make() override { | ||
| AddInput("Input1", "input1"); | ||
| AddInput("Input2", "input2"); | ||
| AddOutput("Output", "output"); |
There was a problem hiding this comment.
give more comments for inputs and output, such as shape, dtype, ...
| #include "paddle/fluid/operators/correlation_op.h" | ||
|
|
||
| #define THREADS_PER_BLOCK 32 | ||
| #define FULL_MASK 0xffffffff |
There was a problem hiding this comment.
put these inside namespace
| limitations under the License. */ | ||
|
|
||
| #pragma once | ||
| #include "paddle/fluid/framework/op_registry.h" |
There was a problem hiding this comment.
can delete this file, put the include in .cc/.cu
| <https://arxiv.org/pdf/1709.02371.pdf>_ | ||
|
|
||
| Args: | ||
| x(Tensor): The input tensor, The data type is float32 and float64. |
qingqing01
previously approved these changes
Sep 8, 2020
lanxianghit
previously approved these changes
Sep 8, 2020
LielinJiang
dismissed stale reviews from lanxianghit and qingqing01
via
22ae3e6
lanxianghit
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
Add correlation api to contrib.